feat(Algebra): characterise when a submodule constructor is equal to `⊥`
PR summary 45d036c35b
Import changes for modified files
No significant changes to the import graph
Import changes for all files
| Files | Import difference |
|---|
Declarations diff
+ toAddSubmonoid_eq_top
+ toSubsemigroup_inj
+ toSubsemigroup_injective
+++ mk_eq_bot
+++ mk_eq_top
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>
The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
Can you point me to somewhere that this is needed?
Is it possible to just add SetLike.ext_iff into your simp call?
I am not that sure if we want this or not.
It is really hard to find again in the diff of #30563, but why would not want these? We have Submodule.coe_eq_zero and do not expect people to rewrite with Submodule.coe_inj backwards afterall.
I do not think they are analogous. Coercion and mk are different.
I don't think we in general should be stating lemmas about mk or should be seeing mk at all.
... but we do have Submodule.mk_eq_zero though, which is even weirder because zero isn't even the simpNF.
If there are already precedent them maybe we can have them...
And can you add the analogous lemmas for top? Thanks.