mathlib4 icon indicating copy to clipboard operation
mathlib4 copied to clipboard

feat: `scoped[NS]` for more commands

Open digama0 opened this issue 1 year ago • 1 comments

The existing code was also quite repetitive and error prone, so we replace it with code that is less repetitive and error prone in a different way.


Open in Gitpod

digama0 avatar Oct 25 '24 12:10 digama0

PR summary 9a0e50a44e

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ elabUpDown

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

github-actions[bot] avatar Oct 25 '24 12:10 github-actions[bot]

@digama0 I stumbled across this PR (through the infinity-cosmos project) and decided to take it up myself and fix the remaining problems.

I hope that's fine by you :)

joneugster avatar Jan 23 '25 16:01 joneugster

@adomani do you have any comments on this? Two natural reviewers contributed to the code so we need someone else to review.

kbuzzard avatar Feb 17 '25 17:02 kbuzzard