mathlib4 icon indicating copy to clipboard operation
mathlib4 copied to clipboard

refactor(MeasureTheory/MeasurableSpace/Card): avoid `Ordinal.toType`

Open vihdzp opened this issue 1 year ago • 2 comments

We redefine generateMeasurableRec so that it's indexed by an ordinal, rather than being indexed by ω₁.toType. We also employ ω₁ and its new API throughout the file.


  • [ ] depends on: #17674

Open in Gitpod

vihdzp avatar Oct 24 '24 18:10 vihdzp

PR summary c3e9a06fbf

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ IsRegular.cof_omega_eq + cardinal_measurableSet_le + generateMeasurableRec_induction + generateMeasurableRec_mono + generateMeasurableRec_of_omega1_le + generateMeasurableRec_omega1 - instance (o : Ordinal) : NoMaxOrder (ℵ_ o).ord.toType

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


Decrease in tech debt: (relative, absolute) = (1.00, 0.00)
Current number Change Type
5095 -1 porting notes

Current commit c3e9a06fbf Reference commit 25f427c356

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

github-actions[bot] avatar Oct 24 '24 18:10 github-actions[bot]

This PR/issue depends on:

  • ~~leanprover-community/mathlib4#17674~~
  • ~~leanprover-community/mathlib4#18541~~
  • ~~leanprover-community/mathlib4#18542~~ By Dependent Issues (🤖). Happy coding!

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

github-actions[bot] avatar Nov 18 '24 10:11 github-actions[bot]

bors merge

kim-em avatar Nov 19 '24 00:11 kim-em

Pull request successfully merged into master.

Build succeeded:

mathlib-bors[bot] avatar Nov 19 '24 00:11 mathlib-bors[bot]