mathlib4 icon indicating copy to clipboard operation
mathlib4 copied to clipboard

chore(TwoSidedIdeal/Basic): fix docs string

Open jjaassoonn opened this issue 1 year ago • 1 comments

After being delegated, I forgot to apply the suggestions from #13902 by @jcommelin ....


Open in Gitpod

jjaassoonn avatar Jul 05 '24 21:07 jjaassoonn

PR summary d0573644a5

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

github-actions[bot] avatar Jul 05 '24 21:07 github-actions[bot]

Thanks for following up! I have just one tiny question; would maintainer merge with that addressed. Did you think about this part of jcommelin's comment?

Then you can use it in theproofs of sub_mem and nsmul_mem etc [...] this isn't very important

grunweg avatar Jul 08 '24 07:07 grunweg

Thanks for following up! I have just one tiny question; would maintainer merge with that addressed. Did you think about this part of jcommelin's comment?

Then you can use it in theproofs of sub_mem and nsmul_mem etc [...] this isn't very important

Thanks for pointing this out. I have applied this suggestion as well!

jjaassoonn avatar Jul 08 '24 09:07 jjaassoonn

Thanks! maintainer merge

grunweg avatar Jul 08 '24 11:07 grunweg

🚀 Pull request has been placed on the maintainer queue by grunweg.

github-actions[bot] avatar Jul 08 '24 11:07 github-actions[bot]

Thanks!

bors merge

riccardobrasca avatar Jul 08 '24 11:07 riccardobrasca

Pull request successfully merged into master.

Build succeeded:

mathlib-bors[bot] avatar Jul 08 '24 11:07 mathlib-bors[bot]