mathlib4 icon indicating copy to clipboard operation
mathlib4 copied to clipboard

fix(GeneralizeProofs): unreachable! bug

Open digama0 opened this issue 1 year ago • 3 comments

As reported on Zulip.


Open in Gitpod

digama0 avatar Jul 05 '24 11:07 digama0

PR summary 4b793a02b2

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

github-actions[bot] avatar Jul 05 '24 11:07 github-actions[bot]

It would be good to have a test demonstrating the fix.

jcommelin avatar Jul 05 '24 17:07 jcommelin

I think this triggers the same unreachable bug:

example (l : List Nat) (h : 1 < l.length) : let i := 2; l.get ⟨1, id h⟩ = 0 := by
  generalize_proofs

kmill avatar Jul 05 '24 17:07 kmill

This pull request has conflicts, please merge master and resolve them.