mathlib4 icon indicating copy to clipboard operation
mathlib4 copied to clipboard

feat(Algebra/Category/Ring/Colimits): category of (possibly non-commutative ring) has colimits

Open jjaassoonn opened this issue 1 year ago • 3 comments

We already have that category of commutative rings has colimits, the same construction works for category of rings.


Open in Gitpod

jjaassoonn avatar Jul 04 '24 15:07 jjaassoonn

PR summary a8d9b6c464

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ ColimitType + ColimitType.AddGroup + ColimitType.AddGroupWithOne + ColimitType.instAdd + ColimitType.instNeg + ColimitType.instZero + InhabitedColimitType + Prequotient + Relation + coconeFun + coconeMorphism + cocone_naturality + cocone_naturality_components + colimit + colimitCocone + colimitIsColimit + colimitSetoid + descFun + descFunLift + descMorphism + hasColimits_ringCat + instance : Inhabited (Prequotient F) + instance : Ring (ColimitType.{v} F) + quot_add + quot_mul + quot_neg + quot_one + quot_zero

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

github-actions[bot] avatar Jul 04 '24 15:07 github-actions[bot]

If it is the same construction, can you show that CommRingCat => RingCat creates all colimits?

erdOne avatar Jul 04 '24 21:07 erdOne

If it is the same construction, can you show that CommRingCat => RingCat creates all colimits?

I just realized I don't understand the maths proof: We need that the colimit of commutative ring viewed as objects of RingCat is still a commutative ring. I am not sure if this true in general. The colimit in RingCat is obtained by quotienting a relation that doesn't mention commutativity anywhere.

jjaassoonn avatar Jul 05 '24 14:07 jjaassoonn

Ah yes you are right. maintainer merge

erdOne avatar Jul 06 '24 14:07 erdOne

🚀 Pull request has been placed on the maintainer queue by erdOne.

github-actions[bot] avatar Jul 06 '24 14:07 github-actions[bot]

bors merge

kim-em avatar Jul 15 '24 21:07 kim-em

Pull request successfully merged into master.

Build succeeded:

mathlib-bors[bot] avatar Jul 15 '24 22:07 mathlib-bors[bot]