mathlib icon indicating copy to clipboard operation
mathlib copied to clipboard

chore(combinatorics/*): Fix lint

Open YaelDillies opened this issue 1 year ago • 4 comments

Fix the linting errors coming from fintype_finite, to_additive_doc and doc_blame. Pull out a [projective_plane P L] assumption to a variables declaration in combinatorics.configuration.


Open in Gitpod

YaelDillies avatar Aug 12 '22 15:08 YaelDillies

This PR also adds additional variable declarations, and changes some proofs (in ways which aren't just renames and fixes). Please add this to be PR description.

b-mehta avatar Aug 12 '22 19:08 b-mehta

The changes to the proof are just adding casesI nonempty_fintype _, as preconized by the fintype_finite linter.

YaelDillies avatar Aug 12 '22 20:08 YaelDillies

There's also the anti-golf in the proof of one_lt_order, and a different proof in coloring.color_classes_finite.

b-mehta avatar Aug 12 '22 20:08 b-mehta

This is all just fintype_finite:

  • The "anti-golf" is required because the previous proof was creating another metavariable midway that appeared in a fintype instance. Now that I need to promote the finite instance to the fintype one, I cannot afford to leave this metavariable.
  • The different proof for coloring.color_classes_finite is because the previous one was calling the fintype V assumption.

YaelDillies avatar Aug 12 '22 20:08 YaelDillies

bors merge p=3

jcommelin avatar Aug 15 '22 19:08 jcommelin

Pull request successfully merged into master.

Build succeeded:

bors[bot] avatar Aug 16 '22 01:08 bors[bot]