mathlib icon indicating copy to clipboard operation
mathlib copied to clipboard

chore(computability/primrec): remove nolints

Open vihdzp opened this issue 2 years ago • 1 comments

We add some documentation, and golf slightly by marking nat.elim and nat.cases as reducible.


Open in Gitpod

vihdzp avatar Aug 11 '22 23:08 vihdzp

I'm not sure if it's a good idea to mark new things as reducible, especially if the only benefit is some golf - sometimes reducible is regarded as code smell; so I'm very hesitant about this change being in a chore nolint PR.

b-mehta avatar Aug 12 '22 19:08 b-mehta

No idea what I was thinking with the reducible tags, they've been reverted.

vihdzp avatar Jan 19 '23 23:01 vihdzp

Thanks!

bors merge

riccardobrasca avatar Jan 23 '23 09:01 riccardobrasca

Pull request successfully merged into master.

Build succeeded:

bors[bot] avatar Jan 23 '23 12:01 bors[bot]