mathlib icon indicating copy to clipboard operation
mathlib copied to clipboard

feat(data/real/dedekind_cut): define and add_comm_group

Open pechersky opened this issue 2 years ago • 5 comments

Based on Principles of mathematical analysis by Rudin TODO: finish proving they form a field, and are isomorphic to the reals.


Open in Gitpod

pechersky avatar Jun 08 '22 05:06 pechersky

Have you seen concept? This is a generalization of Dedekind cuts. Also I think your pointwise lemmas are all abstracted away in #13669 (by showing that Sup preserves addition, multiplication). And finally the "isomorphic to the reals" part will be a direct consequence of #3292.

YaelDillies avatar Jun 08 '22 19:06 YaelDillies

Have you seen concept? This is a generalization of Dedekind cuts. Also I think your pointwise lemmas are all abstracted away in #13669 (by showing that Sup preserves addition, multiplication). And finally the "isomorphic to the reals" part will be a direct consequence of #3292.

Would you suggest abandoning this? My goal is to place an "archimedean linear ordered field" instance on this type that I am building. Would we do it instead on concept?

pechersky avatar Jun 08 '22 19:06 pechersky

Actually, there is one difference. Namely, Dedekind cuts don't give you and . Still, I think this should wait for #3292 because this is quite literally what it is designed for (the head of the queue is #14307).

YaelDillies avatar Jun 08 '22 20:06 YaelDillies

#3292 will allow us to how that cut Q \~- R, but we still need to build that cut Q is archimedean linear field. Am I missing something?

pechersky avatar Jun 08 '22 20:06 pechersky

No no, that's right. But your todo is about the isomorphism to the reals, and my point is that you don't actually need to do that part.

YaelDillies avatar Jun 08 '22 20:06 YaelDillies