lean4web icon indicating copy to clipboard operation
lean4web copied to clipboard

Add support for building on Windows

Open kant2002 opened this issue 7 months ago • 5 comments

kant2002 avatar May 24 '25 06:05 kant2002

@joneugster May I have your attention please?

kant2002 avatar May 29 '25 07:05 kant2002

Thanks for the PR! I'll try to have a closer look next week. I'm a bit confused why you want to delete or rename the existing .sh files

Also if you extended the existing github actions (under .github) to run on Windows too and test your setup, it would be easier to ensure your code works and to merge

joneugster avatar May 29 '25 08:05 joneugster

the only reason why I rename them, so when you run ./build on the terminal, in windows it will first look for .bat and for .cmd files. so that effectively make it friendly for docs on both platforms, without complicated ifs.

I will take a look at .github actions. That's for the hint.

kant2002 avatar May 30 '25 07:05 kant2002

@joneugster sorry for delay with Windows build, but can allow run this pipeline?

kant2002 avatar Jun 26 '25 15:06 kant2002

I have approved, but if this just for testing purposes, I think it would be easier if you ran the actions on your own fork. The build.yml file currently restricts actions to run only on dev and main branches. If you remove that restriction, the actions should start to run on the kant/add-windows-build branch of your fork as well.

abentkamp avatar Jun 26 '25 19:06 abentkamp