Adding evil keybindings

[lenianiva]

Is it possible to bundle evil keybindings into this package? I made some keybindings for the existing commands (doomemacs)

(map! :after lean4-mode
	:localleader
	:map lean4-mode-map
	:desc "Execute"               "R" #'lean4-execute
	:desc "Execute in standalone" "r" #'lean4-std-exe
	:desc "Toggle info buffer"    "t" #'lean4-toggle-info
	(:prefix ("e" . "Error")
		:desc "Previous error"      "p" #'flycheck-previous-error
		:desc "Next error"          "n" #'flycheck-next-error
		:desc "List error"          "l" #'flycheck-list-errors
		)
	:desc "Lake build"            "b" #'lean4-lake-build
	(:prefix ("p" . "leanpkg")
		:desc "Test"                "t" #'lean4-leanpkg-test
		:desc "Build"               "b" #'lean4-leanpkg-build
		:desc "Configure"           "c" #'lean4-leanpkg-configure
		)
	)

[urkud]

Can you prepare a pull request? I guess, the less work you leave to maintainers, the higher the probability of getting it merged. What do other packages do about configurability of evil keybindings?

[mekeor]

There are several ways how evil keybindings can be provided:

• In a separate repository. For example, for the anzu package, evil-anzu is provided in a separate repository: https://github.com/emacsorphanage/evil-anzu
• As part of evil-collection package: https://github.com/emacs-evil/evil-collection/tree/master/modes
• We could add evil-lean4 or lean4-evil as a separate package but in the same repository. Just like kubel provides evil-kubel: https://github.com/abrochard/kubel