lean icon indicating copy to clipboard operation
lean copied to clipboard

chore(init/data/set): Delete

Open YaelDillies opened this issue 3 years ago • 10 comments

To be (obviously!) restored on the mathlib side. Followup to #675

YaelDillies avatar Jun 05 '22 16:06 YaelDillies

Feel free to move the rest to mathlib as well. Except for set_of because that's referenced by Lean.

Should we leave set_of here?

fpvandoorn avatar Jun 06 '22 09:06 fpvandoorn

Oh, I missed this. Where is it referenced?

YaelDillies avatar Jun 06 '22 09:06 YaelDillies

Probably in the C++ code, on how to parse { ... | ... }.

fpvandoorn avatar Jun 06 '22 09:06 fpvandoorn

Then again, I don't think it causes any problems if we move this to mathlib, except that you'll get an error when writing { ... | ... } before you import the appropriate file. But I'd like to let @gebner chime in on that.

fpvandoorn avatar Jun 06 '22 09:06 fpvandoorn

I believe set_of is the only reason some of the set definition is still in core (see https://github.com/leanprover-community/lean/pull/675#issuecomment-1024411237). There's also a test that checks whether every definition referenced from the C++ side actually exists in the library: bors try

gebner avatar Jun 06 '22 10:06 gebner

try

Build failed:

bors[bot] avatar Jun 06 '22 10:06 bors[bot]

Relevant line in the build failure: init.data.basic cannot find init.data.set.

fpvandoorn avatar Jun 07 '22 09:06 fpvandoorn

bors try

eric-wieser avatar Jun 24 '22 00:06 eric-wieser

try

Build failed:

bors[bot] avatar Jun 24 '22 00:06 bors[bot]

Looks like there are 24 failing tests (search for ***Failed in the logs to find them)

eric-wieser avatar Jun 24 '22 08:06 eric-wieser