batteries icon indicating copy to clipboard operation
batteries copied to clipboard

feat: Shake autodetects which module(s) to shake

Open Vierkantor opened this issue 8 months ago • 2 comments

There were still a few references to Mathlib in Shake, in particular it had Mathlib hardcoded as the default module to shake. Instead ask Lake what the default targets are.

(Also remove a reference to Mathlib from the help text. We still have Mathlib as an example usage, which I think is innocent enough and can stay.)

Depends on: #1204

Vierkantor avatar Apr 10 '25 13:04 Vierkantor

Tested that this does the right thing on Mathlib.

Vierkantor avatar Apr 10 '25 13:04 Vierkantor

Mathlib CI status (docs):

What is the status of this PR?

fgdorais avatar Jun 03 '25 21:06 fgdorais

My understanding is that the equivalent PR has landed in mathlib, so this PR can be closed. (If shake were to be upstreamed to batteries, #1204 should be updated.) That said, my reading of the zulip discussion was also that moving shake to batteries had no consensus, and a separate repository might be better.

grunweg avatar Jun 04 '25 11:06 grunweg