graphql-spqr-spring-boot-starter icon indicating copy to clipboard operation
graphql-spqr-spring-boot-starter copied to clipboard

Published 20 hours ago • verified publisher icon leangen

improve query param handling fixes #58

Open Andy2003 opened this issue 5 years ago • 1 comments

improve query param handling fixes #58

Andy2003 avatar Oct 28 '19 15:10 Andy2003

Sorry for the huge delay, and thanks a bunch for this! Unfortunately, you introduced a direct dependency to Jackson which is problematic, as Jackson might not be available. Both SPQR and Spring work with other libraries and must adapt to whterever is configured. A way to work around this is to abstract the deserialization either behind SPQR's own ValueMapper, or Spring's HttpMessageConverter (which is intended for parsing message bodies but can be abused for query params). If you wish, I can take it over and make the changes to your branch (assuming you allowed me when making the PR), so that you commits stay. Or you can keep working on it? Ping me on Gitter if you wish to consult.

kaqqao avatar Jan 31 '20 19:01 kaqqao