Leandro Beretta

Results 52 comments of Leandro Beretta

Did a first run on Minikube and works well and I really like how it looks and how the information is grouped. ![image](https://github.com/kiali/kiali/assets/1286393/34314c0f-3437-435e-b351-8e18f8b3ed7b) The collapsible namespaces for the data plane...

> Hello @leandroberetta, since main branch have the playwright tests already fixed, can you please add some regression before merging this PR? Thank you 🙏 We decided to merge this...

> This need to be rebased (Error about kiali version). I am going to install that verswion to test it I'm using v1.86 to test this, isn't ok?.

> * Graph card not work for me. If we are going to add this in this PR I would add some tests due this will be supported. Yes, I...

I addressed, I think, everything needed: - Added minimal testing (more will be added on follow up PR) - Added dark mode support - Added a minimal control bar (zoom...

> Thanks @leandroberetta , some comments were addressed: > > * The dark mode was fixed > ![image](https://private-user-images.githubusercontent.com/49480155/349460849-cb0f2956-7ee7-4595-9614-6c6d215e0383.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjEzNjExNTksIm5iZiI6MTcyMTM2MDg1OSwicGF0aCI6Ii80OTQ4MDE1NS8zNDk0NjA4NDktY2IwZjI5NTYtN2VlNy00NTk1LTk2MTQtNmM2ZDIxNWUwMzgzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzE5VDAzNDczOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTE0MDNkOGMyNzA1NTY1N2Q5MWJkMDJkMWMzODM5NTI5MjQ2Mjk0MDViZDE5MTQ0MWJkZmZkNDA4NzYzN2M1ZDEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.vz-lSNSqnZtx77mCANNOqLXfirlRtaQD4mtgBSQzbZ0) > * Graph card added > ![image](https://private-user-images.githubusercontent.com/49480155/349461125-228c4993-b981-4726-9fdd-e501bd6d0e69.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjEzNjExNTksIm5iZiI6MTcyMTM2MDg1OSwicGF0aCI6Ii80OTQ4MDE1NS8zNDk0NjExMjUtMjI4YzQ5OTMtYjk4MS00NzI2LTlmZGQtZTUwMWJkNmQwZTY5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzE5VDAzNDczOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTRjZTU2YzQ1YjBhNzdkYTcxNGJiZmFlMjA5NzVlODA3NDU4YjM5MTRmODVmYmQwMzhmM2Y4MGYzYzc0ZDJhNGEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.bS7S3hHt7FxopKZl3uD8XERdNDW_SehHeYw74XTxv0I) > * zoom buttons added...

Hi @aljesusg, I'm noticing this graph is based on Cytoscape, but I thought we want the new PF graph for this effort, is there any reason for having the Cy...

> > Hi @aljesusg, I'm noticing this graph is based on Cytoscape, but I thought we want the new PF graph for this effort, is there any reason for having...

I think I prefer moving to Python or Go, I'm fine with bash but I'm not so use to write it and sometimes I feel lost when something breaks. Having...

> Thanks, @leandroberetta, it looks good! Just a couple of small comments: > > ![image](https://private-user-images.githubusercontent.com/49480155/454421908-360b59b0-7ee9-46a6-9482-9f235389b25a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDk3MzU4MTksIm5iZiI6MTc0OTczNTUxOSwicGF0aCI6Ii80OTQ4MDE1NS80NTQ0MjE5MDgtMzYwYjU5YjAtN2VlOS00NmE2LTk0ODItOWYyMzUzODliMjVhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA2MTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNjEyVDEzMzgzOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWFjOWEzNTA1NGRkMTdmOGIyYzY2ZjcxOGVlNGFmZmY2NjIwYzkyYzJmZTM5NDQ5MzVlNDg5NmNkNWZhNmNhODgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.D6aL6PpvPKZVs9WcAZgaw09sx-vqCsqyfujqa7fkUZE) > > I think it would be better to remove the scroll, as it is...