patrol icon indicating copy to clipboard operation
patrol copied to clipboard

isPermissionDialogVisible Only works with the app language being English.

Open duchv-selex opened this issue 1 year ago • 6 comments

Use case

When my app is support multiple language. isPermissionDialogVisible can't execute because patrol execute text by English

Proposal

I think we should has a optional for execute when the app is other language without English

duchv-selex avatar Aug 10 '24 05:08 duchv-selex

Hi @duchv-selex ~Could you provide some more details? I've just rechecked this test from example app https://github.com/leancodepl/patrol/blob/master/packages/patrol/example/integration_test/main_test.dart#L51 on both iOS and Android simulators with Polish language set up (popups were correctly with Polish texts) and this test passed.~

zoskar avatar Aug 12 '24 11:08 zoskar

@duchv-selex Actually, I was wrong, sorry for that. What I described above works on Android. If you try to use those native commands (isPermissionDialogVisible etc.) on iOS, they will only work with English. I will add feature label (feature request).

For now you can only work with those permissions on iOS in other languages by using String selectors.

zoskar avatar Aug 12 '24 11:08 zoskar

For now you can only work with those permissions on iOS in other languages by using String selectors.

@duchv-selex Remember to set appId argument to com.apple.springboard on iOS! :)

jBorkowska avatar Aug 12 '24 12:08 jBorkowska

@jBorkowska I don't really understand what you mean.

duchv-selex avatar Aug 13 '24 01:08 duchv-selex

@zoskar Thank you for you support.

duchv-selex avatar Aug 13 '24 01:08 duchv-selex

@duchv-selex The comment above suggested, that if you want to implement tapping on your permission dialog in other language on iOS, you would need sth like:

    await $.native.tap(
      Selector(text: 'your text'),
      appId: 'com.apple.springboard',
    );

zoskar avatar Aug 13 '24 07:08 zoskar

Should be fixed in next patrol release. If some langauge that you need is missing you can contribute https://github.com/leancodepl/patrol/blob/master/CONTRIBUTING.md

Kendru98 avatar Aug 01 '25 12:08 Kendru98

This issue has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar problem, please file a new issue. Make sure to follow the template and provide all the information necessary to reproduce the issue.

github-actions[bot] avatar Aug 12 '25 13:08 github-actions[bot]