patrol icon indicating copy to clipboard operation
patrol copied to clipboard

Resolves an issue where test bundler would generate invalid code if the file path included dashes

Open kodypeterson opened this issue 1 year ago • 2 comments

Identified an issue where having dashes (-) in your file path would result in invalid dart code being generated.

kodypeterson avatar Feb 20 '24 23:02 kodypeterson

Thanks for the PR. We recently opened a topic of the separators and wanted to change them into something which would work universally and I like this idea. But before we will go with it we need to make sure that it will not break running tests on device farms (some of them parses the output of the console and expect it to be in specific form).

piotruela avatar Feb 25 '24 21:02 piotruela

Hi @kodypeterson! Could you create the issue with a reproducible sample with this one? We would like to investigate it, but I'm not sure if the PR is the right place for it, especially that we might want to choose another approach to that issue.

mateuszwojtczak avatar Jun 14 '24 08:06 mateuszwojtczak

Closing this for now, @kodypeterson feel free to re-open it when you're ready

mateuszwojtczak avatar Sep 05 '24 08:09 mateuszwojtczak