ChatKit-OC icon indicating copy to clipboard operation
ChatKit-OC copied to clipboard

继承了LCCKConversationViewController导致bundle加载不到

Open mokai opened this issue 8 years ago • 4 comments

Base Info for this issue

继承了LCCKConversationViewController导致部分依赖[self class]来取bundle的代码取不到。 如LCCKConversationViewController.m 行914 didTapLinkText方法中取Alert的title使用了LCCKLocalizedStrings,其定义

NSLocalizedStringFromTableInBundle(key, @"LCChatKitString", [NSBundle lcck_bundleForName:@"Other" class:[self class]], nil)

改成以下代码后正常

NSLocalizedStringFromTableInBundle(key, @"LCChatKitString", [NSBundle lcck_bundleForName:@"Other" class:[LCChatKit class]], nil)
  1. ChatKit Version:0.8.5
  2. App-ID: XX
  3. Language:Swift
  4. iOS System Version:iOS10
  5. Prototype(是否是真机):YES
  6. Issue Type:Crash、Bug、Enhancement(希望能支持一个新需求)、Q-A

1. How to repeat the problem.

2. Please help me in this way.

3. Here is a Demo.

4. Here is my Debug log

mokai avatar Sep 12 '17 02:09 mokai

的确有这个问题,建议提pr吧。

ChenYilong avatar Sep 12 '17 02:09 ChenYilong

https://github.com/leancloud/ChatKit-OC/pull/352 已提PR

mokai avatar Sep 22 '17 13:09 mokai

@tang3w

ChenYilong avatar Sep 23 '17 07:09 ChenYilong

fix in CYLChatKit https://github.com/ChenYilong/CYLChatKit/releases

changelog:

2.1.1 update voice message send UI same to wechat

ChenYilong avatar Jun 14 '18 17:06 ChenYilong