leamas
leamas
Should be fixed by update to 24.04 runtime. Final test in beta cycle
Fixed in 5.12. Closing
> I doubt it. It has nothing to do with Windows Operating System versions. The possible exception would be if the msvc libs requires something not available in win 7,...
> however I am unclear about the relationship between cli/api_shim.cpp and include/ocpn_plugin.h We compile two type of targets, both uses _ocpn_plugin.h_. For the opencpn target, _ocpn_plugin.h_ is implemented in too...
I'm a bit sceptical to these sort of changes. To make them, we need to check a big multi dimensional text matrix taking OS, screens and overall colour scheme into...
You can mark your work as a WIP in the right panel: "Convert to draft"
I can see some problems here. However, don't have the time for a full review, sorry.
While on it: Could you please remove this line: ``` diff --git a/model/src/plugin_handler.cpp b/model/src/plugin_handler.cpp index d15a40537..c7f4f109a 100644 --- a/model/src/plugin_handler.cpp +++ b/model/src/plugin_handler.cpp @@ -1437,7 +1437,6 @@ bool PluginHandler::installPluginFromCache(PluginMetadata plugin) { MESSAGE_LOG
Thanks for PR and patience !
@sebastien-rosset : Two final notes: - You had not run clang-format on the affected files. Fixed in master. I'd suggest that you update your environment as described in the manual...