cosmere icon indicating copy to clipboard operation
cosmere copied to clipboard

Mistcloak v2

Open SoaringEaqle opened this issue 5 months ago • 7 comments

Changes proposed in this pull request:

Fixes mistcloak render by making it a Curios item to go in the head slot. Overhauls Shardplate

  1. Shardplate is now one Curios item instead of four armor pieces.
  2. 10 new Shardplate items, one for each order minus Bondsmiths plus deadplate
  3. Dynamic models for shardplate
  4. Shardplate is a chargable item that can be restored by
  • crafting with broams with stormlight
  • siphoning from surgebinders
  1. Shardplate adds buffs when charged and problems when empty.
  2. shardplate buffs are handled in ShardplateCurioItem class instead of SurgebindingSpiritwebSubmodule

SoaringEaqle avatar Jul 24 '25 03:07 SoaringEaqle

There's some stuff that still needs done, but it's mostly to do with how radiant shardplate works and interacts with radiants, so it's probably best to add it after radiants get added. Instead of working around a system that barely exists yet.

SoaringEaqle avatar Jul 24 '25 03:07 SoaringEaqle

Needed a break from Investiture System, so mostly redid this. Hopefully this redesign makes it easier to influence data, and manipulate deadeye states, as well as control bonding easier.

SoaringEaqle avatar Oct 09 '25 06:10 SoaringEaqle

Don't see any issues with the Mistcloak.

However, when I go to change out one piece of Shardplate for another, the second one becomes the same type as the first. This happens regardless of Dead or living plate.

SurgebindingItemModelsGen.java is also missing a couple imports for GemstoneItem and ShardplateCurioItem.

I also get java.lang.IllegalArgumentException: Texture surgebinding:item/gemstone_chip does not exist in any known resource pack when I try to runData, which I was doing to see if the lack of a Curios slot name for Shardplate was just because I hadn't generated.

Gerbagel avatar Nov 14 '25 23:11 Gerbagel

I did notice that, however, I do not know how to fix it. My assumption is that it is a quirk with curios. I think the best way to bypass it would be to store the data somewhere when you try to equip, and come back a few ticks later and reattach the data, but I really have no clue what that would look like.

SoaringEaqle avatar Nov 15 '25 02:11 SoaringEaqle

In future, we also don't want multiple features packed into a single pull request. This one is called mistcloak, but is mostly full of surgebinding stuff.

leafreynolds avatar Nov 15 '25 03:11 leafreynolds

Sorry about that. I just needed a bunch of stuff I made for the mistcloak for the Shardplate, and I didn't want to go through the effort of duplicating the branch and removing the mistcloak-specific code.

SoaringEaqle avatar Nov 15 '25 08:11 SoaringEaqle

SurgebindingItemModelsGen.java is also missing a couple imports for GemstoneItem and ShardplateCurioItem.

I also get java.lang.IllegalArgumentException: Texture surgebinding:item/gemstone_chip does not exist in any known resource pack when I try to runData, which I was doing to see if the lack of a Curios slot name for Shardplate was just because I hadn't generated.

These two issues should be resolved. It was some issue where the files half updated, but not completely.

SoaringEaqle avatar Nov 15 '25 08:11 SoaringEaqle