cosmere icon indicating copy to clipboard operation
cosmere copied to clipboard

Port to 1.20.x

Open leafreynolds opened this issue 1 year ago • 6 comments

Remaining work

  • [x] Data generation code
  • [x] Fix curio slots
  • [x] metal vial custom recipe
  • [x] tools itemgroup -> creative tabs
  • [x] Feruchromium not increasing fortune
  • [x] Cosmere copper ingots should be replaced with vanilla variant
  • [x] Refactor all uses of SomeEnum.values() to one class, so as to not assign new memory when called. It should do it once on construction in a unified enumsutils class or something
  • [x] initial settings for ore generation
  • [x] fix vanilla night vision?
  • [ ] #121

leafreynolds avatar Mar 24 '24 22:03 leafreynolds

Best of luck Leaf!!

DiceOf20 avatar May 01 '24 10:05 DiceOf20

Good luck Leaf, you can do it!! Strength before Weakness!

R0b0r0b avatar May 01 '24 12:05 R0b0r0b

Fixed f-chromium in 9480f55a1aa4b81ae41a365598899da1a8e5b33d

Gerbagel avatar Nov 03 '24 14:11 Gerbagel

Nice one, Gerbagel! Though Leaf, I'm not sure that you should replace Cosmere copper ingots with vanilla ones - I've found that vanilla copper, once it's become exposed or weathered, no longer qualifies as Pushable/Pullable. (Or just make the weathered/exposed variants also Pushable/Pullable, now I think about it!)

R0b0r0b avatar Nov 03 '24 14:11 R0b0r0b

Nice one, Gerbagel! Though Leaf, I'm not sure that you should replace Cosmere copper ingots with vanilla ones - I've found that vanilla copper, once it's become exposed or weathered, no longer qualifies as Pushable/Pullable. (Or just make the weathered/exposed variants also Pushable/Pullable, now I think about it!)

This we fix :) Should just be a datapack change to add those specifically as pushable

Gerbagel avatar Nov 03 '24 14:11 Gerbagel

@MoonlitJolteon Let me know when you get a chance to check Sandmastery :)

leafreynolds avatar Jan 15 '25 19:01 leafreynolds