lessphp icon indicating copy to clipboard operation
lessphp copied to clipboard

Better variable inheritance

Open nathanntg opened this issue 10 years ago • 3 comments

I was seeing a problem compiling Bootstrap 2.3.2 where the fluid widths were not correctly preserved in the responsive design. This was due to an issue where the mixin scope took precedence over the normal variable inheritance chain. This commit ensures that the standard inheritance chain is fully traversed before considering mixin scope.

There is likely a more graceful way to do this, but I did at least want to offer this solution in case others are running into the same issue.

nathanntg avatar Jan 13 '15 17:01 nathanntg

added in https://github.com/MarcusSchwarz/lesserphp/releases/tag/v0.5.1

glensc avatar Aug 17 '17 20:08 glensc

This seems fine but I'm hesitant to merge without a test case to confirm it, and also to avoid regressing it in the future.

Krinkle avatar Oct 16 '18 03:10 Krinkle

@Krinkle Unfortunately, I don't remember the original LESS that led me to create this modification. It was something in the Bootstrap 2 library... I tried rerunning the code on a few old versions, but was not able to easily identify the issue.

Sorry for not adding the test case originally.

Probably best to close this until someone posts an issue that can be used to confirm that this is indeed the desired behavior.

nathanntg avatar Oct 16 '18 20:10 nathanntg