contrast() now accepts percentage threshold

[atkaye]

Fixes leafo/lessphp#501

[leafo]

spec? :smiley:

[atkaye]

@threshold as percentage string rather than just decimal as per http://lesscss.org/#reference: contrast(@color1, [@darkcolor: black], [@lightcolor: white], [@threshold: 43%]);

Sound good?

[leafo]

Sorry I meant adding a test to here: https://github.com/leafo/lessphp/blob/master/tests/inputs/colors.less

Edit: updated with correct file

[atkaye]

Got ya... added tests as above

[atkaye]

Nudge :smile:

[jonmilsom]

This looks really useful... @leafo please can you merge?

[glensc]

added in https://github.com/MarcusSchwarz/lesserphp/releases/tag/v0.5.1

[Krinkle]

It seems the tests are not passing correctly:

Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
   color3: #ffffff;
-  color4: #000000;
-  color5: #000000;
+  color4: #ffffff;
+  color5: #ffffff;
 }

I've confirmed with less.js that the way the test was written, has the correct 'Expected' value. But the currently produced 'Actual' isn't as it should be.

[Krinkle]

I've published a rebased version to a pull-523 branch.