gh-actions-lua icon indicating copy to clipboard operation
gh-actions-lua copied to clipboard

feat: update deps and bundle app

Open lewis6991 opened this issue 9 months ago • 9 comments

  • actions/cache: 3.1.2 -> 4.0.3

  • actions/core: 1.2.6 -> 1.11.1

  • actions/exec: 1.0.4 -> 1.1.1

  • actions/io: 1.0.2 -> 1.1.3

  • actions/tool-cache: 2.0.1 -> 2.0.2

  • Specifically update actions/cache to v4 as the backends for v3 have now been retired.

  • Bundle action using esbuild and remove node_modules

    • I'd normally do this in a separate PR, but the dependency updates increased the size of node_modules substantially to the point that pushing this commit took a fair few seconds

lewis6991 avatar May 29 '25 21:05 lewis6991

See https://github.com/orgs/community/discussions/160793#discussioncomment-13313237

lewis6991 avatar May 29 '25 21:05 lewis6991

Please @leafo merge this and ship a new release. Our pipeline time increased from ~3 minutes to ~20, because of the broken caching.

BreakBB avatar May 30 '25 20:05 BreakBB

Fixes #57

McTalian avatar May 31 '25 14:05 McTalian

I'm also affected by this, pipelines are 15 min longer. Please merge this PR.

fernandes6502 avatar Jun 02 '25 12:06 fernandes6502

I'm doing this while waiting for the official release:

      - uses: lewis6991/gh-actions-lua@01aab24c4de9555717b685f9b142a2abbe12ef14
        with:
          luaVersion: 5.3.5

Works like a charm, thanks @lewis6991 !

McTalian avatar Jun 07 '25 15:06 McTalian

We changed to this:


steps:
      - name: Install Lua
        run: |
          sudo apt-get install lua5.1 lua-check luarocks
          sudo luarocks install bit32
          sudo luarocks install busted

No extra action required and it's way faster.

BreakBB avatar Jun 08 '25 07:06 BreakBB

Do you have anything for windows?

lewis6991 avatar Jun 08 '25 09:06 lewis6991

I don't have any Windows idea @lewis6991 if your question meant me. I currently don't use any Windows image in a CI environment 🤷 Not sure if WSL can be used, where the code I posted above might work.

BreakBB avatar Jun 08 '25 20:06 BreakBB

If you want to directly install Lua on a Windows host you might be able to use winget. Although not sure how or if version selection works there (note the install lua5.1 in the example above, which runs on a ubuntu-latest host).

Muehe avatar Jun 14 '25 04:06 Muehe