leaflet-providers icon indicating copy to clipboard operation
leaflet-providers copied to clipboard

Updates to MapTiler and NLS

Open D-Groenewegen opened this issue 1 year ago • 8 comments

MapTiler updates:

  • updated NLS (National Library of Scotland), taking into account that different resources use different formats (jpg, png or none at all) and zoom levels, + added Bartholomew Quarter Inch map of Ireland, again from NLS. Note that NLS is credited as the provider of the Bartholomew Quarter Inch map on a separate webpage.
  • new MapTilerTiles, those at least that are supported by Leaflet.

D-Groenewegen avatar Nov 08 '24 15:11 D-Groenewegen

Just a moment. For some reason I forgot to add 'options' first!

Update: should be fine now.

D-Groenewegen avatar Nov 08 '24 15:11 D-Groenewegen

Thx !

Primary this should be rebased with a proper commit log, can you do it please ?

I'm not sure about adding pbf tiles since it depends on an external plugin. To me, the principle of leaflet provider is to provide tiles ready to user with leaflet. Any thoughts about this @jieter ?

brunob avatar Nov 08 '24 19:11 brunob

I'm certain that mixing xyz tiles with pbf would cause a lot of confusion downstream. It would certainly break everything over in Python where we consume leaflet-providers data.

martinfleis avatar Nov 08 '24 20:11 martinfleis

@martinfleis ths for the feedback & thx also @D-Groenewegen for the update.

brunob avatar Nov 09 '24 18:11 brunob

@brunob is something blocking this from merging? I'd like to use updated MapTiler maps.

petr-hajek avatar Mar 06 '25 09:03 petr-hajek

@brunob is something blocking this from merging? I'd like to use updated MapTiler maps.

Nothing was blocking but "we" have to fix #627 now before going further + i'm just waiting feedback from @jieter on this PR :)

brunob avatar Mar 06 '25 09:03 brunob

Yes something is blocking, as i already asked :

Primary this should be rebased with a proper commit log, can you do it please ?

  • all commits should be squashed in one

brunob avatar Mar 07 '25 12:03 brunob

@D-Groenewegen

petr-hajek avatar Mar 07 '25 16:03 petr-hajek