leaderboard-site icon indicating copy to clipboard operation
leaderboard-site copied to clipboard

Task: Update base input to include binding for $listeners

Open maxcaplan opened this issue 3 years ago • 3 comments

What are you wanting to be added?

The input base component currently is set up just for v-model so other event binding cannot be done.

What might break?

When adding v-on="$listeners", v-model returns an input event as apposed to the proper data.

Relevant Issues

No response

maxcaplan avatar Aug 08 '21 23:08 maxcaplan

The input base component

Which component is this? I can't find anything that has v-model

joshuasmall avatar Oct 21 '21 17:10 joshuasmall

I think it was first made in here, which hasn't landed yet https://github.com/speedrun-website/speedrun.website/pull/14

erunks avatar Oct 21 '21 22:10 erunks

We shouldn't need any of this, as long as the input is the top element of the template and if inheritAttrs is set to true (already true by default). Same goes for all the base components basically.

CapitaineToinon avatar Oct 23 '21 16:10 CapitaineToinon

@CapitaineToinon do you think we're good to close this then?

erunks avatar Jan 20 '23 22:01 erunks

Closing this, as we apparently don't need it anymore

erunks avatar Jan 23 '23 16:01 erunks