Oleksii Vasyliev

Results 72 comments of Oleksii Vasyliev

ok, got a problem. Maybe this commit will be enough - https://github.com/activerecord-hackery/ransack/pull/1525/commits/aa2062c922de01e767db9f3d270edf13cbce01f0

Looks like it is influence not only on tests, but also registration is not working in application due to same error

question here: should `mask.masked(mask.unmasked(a)) === a` or we should expect non deterministic results? @rozsazoltan - it is number (float), not integers. and it lost fraction

I think problem, that for `mask.masked` it should not expect value in `opts.locale`, but in locale, which it did `mask.unmasked`, which looks like `en`

Yes, but why `mask.masked(mask.unmasked(a)) === a` non deterministic? If you return `unmasked` in locale, which you not expect to handle in `masked`, this mean logic is incorrect.

```js const mask = new Mask({ number: { locale: 'pt-BR', fraction: 2 } }) Intl.NumberFormat('pt-BR').format(10234.54) // 10.234,54 mask.masked('10.234,54') // 10.234,54 - same, just waste cpu time ``` as I understand,...

@beholdr I think stuff like "parsing" and "formating" need to be split, so parsing can work with normal numbers (not only based on locale), while "formating" do format based requested...

> works best with self contained, well defined bugs in this case for now it useless, because such task can do even beginner developer :)

it is possible to do, but no server here - it may require re-render after parsing query params