bitsy icon indicating copy to clipboard operation
bitsy copied to clipboard

Render animation thumbnail sometimes uses incorrect palette

Open nashalexander opened this issue 2 years ago • 1 comments

Environment

MacOS Firefox 108.0.2 (64-bit)

Replicate issue

  1. Have two rooms and two palettes, room 0 has palette 0, room 1 palette 1
  2. Switch the room editor to room 1
  3. Playtest the game, which will begin play testing with room 0
  4. Stop play testing. The room editor will switch back to room 1, however the graphical issue below will occur.

Description

I noticed at some point when editing a game, the animation thumbnails began using the incorrect palette colors and the incorrect values from that palette.

This screenshot displays the room's selected palette in the palette tool. Screen Shot 2023-01-06 at 10 53 36 PM

This screenshot displays the other palette I have, which is not the room's selected palette. Notice how the preview is using the incorrect colors from that palette as well for the background and sprite colors. Screen Shot 2023-01-06 at 11 13 51 PM

Temporary Fix

Switching from one room and back to the other fixes the issue. So I'm assuming there was some issue that created a mismatch between the stored room id and the actual room tool's id.

nashalexander avatar Jan 07 '23 04:01 nashalexander

thanks for the bug report and the detailed repro steps @nashalexander! this will definitely help me investigate :)

le-doux avatar Jan 22 '23 21:01 le-doux

doesn't repro anymore - I think changes I made to how the renderer caching works may have fixed this one

le-doux avatar Apr 26 '24 00:04 le-doux