minecolonies icon indicating copy to clipboard operation
minecolonies copied to clipboard

Bug 10952

Open armele opened this issue 6 months ago • 2 comments

Closes #10952

Changes proposed in this pull request

  • Minor change to assignment logic (defect caused by reversed logic on
  • Refactoring to allow logging of root cause in valid situations where assignment should not succeed.

Testing

  • [X] Yes I tested this before submitting it.
  • [ ] I also did a multiplayer test.

Review please

armele avatar Jun 16 '25 14:06 armele

Log messages are not super useful without context such as colony, work order, and builder ids and/or names.

uecasm avatar Jun 17 '25 02:06 uecasm

Good point... added relevant information. If someone is not looking at the logs, though, it still appears to do nothing when the assign button is pressed in these situations. Should I instead make it an in-game message sent to the clicking player, so the feedback is obvious and immediate?

armele avatar Jun 17 '25 10:06 armele