minecolonies icon indicating copy to clipboard operation
minecolonies copied to clipboard

New way of doing research is busted for datapacking (Name)

Open Shadizar opened this issue 6 months ago • 4 comments

Is there an existing issue for this?

  • [x] I have searched the existing issues.

Are you using the latest MineColonies Version?

  • [x] I am running the latest beta/release version of MineColonies for my Minecraft version. I am also running the latest versions of other mods that are part of my problem.

Did you check on the Wiki? or ask on Discord?

  • [x] I checked the MineColonies Wiki and made sure my issue is not covered there. Or I was sent from discord to open an issue here.

What were you playing at the time? Were you able to reproduce it in both settings?

  • [x] Single Player
  • [x] Multi Player

Minecraft Version

1.20

MineColonies Version

1.1.909

Structurize Version

1.0.773

Related Mods and their Versions

N/A

Current Behavior

When I try to structure my researches according to the new way, it errors about the Name and doesn't work. The datagenned ones don't show a Name. The wiki has no guidance (it is geared to the Old Ways)

Expected Behavior

Able to specify a working Name in my JSON

Reproduction Steps

Edit research JSON to fit new format Save Reload Errors

Logs

not yet available

Anything else?

discussion at https://discord.com/channels/139070364159311872/976625343358189618/1381083646605266945

Footer


Viewers

  • Add a thumbs-up to the bug report if you are also affected. This helps the bug report become more visible to the team and doesn't clutter the comments.
  • Add a comment if you have any insights or background information that isn't already part of the conversation.

Shadizar avatar Jun 08 '25 02:06 Shadizar

Please provide example json that you're expecting to work and isn't. AFAIK there aren't any changes to how research names are parsed, just item costs.

uecasm avatar Jun 08 '25 04:06 uecasm

So before I make the change here's the log snip prompting me to do updates. (I'll have actual log and problem updates after this, just recording this for information).

[08:42:17] [Render thread/WARN]: Research 'archwoodcollective:arsnouveau/arswildenprocessing' requirement #0 is missing the required 'type' property. [08:42:17] [Render thread/WARN]: Research 'archwoodcollective:arsnouveau/arscraftingrecipes' requirement #0 is missing the required 'type' property. [08:42:17] [Render thread/WARN]: Research 'archwoodcollective:arsnouveau/arsadvancedwildenprocessing' requirement #0 is missing the required 'type' property.

However the research, as expected. loads, has a good name, and seems working.

Image

(again: please hold for next comment...getting the updates/logs/image ready)

Shadizar avatar Jun 08 '25 15:06 Shadizar

well shoot. this time it seemed to work, and I have no idea why, as I feel I did the exact same steps as I did the other time. I guess, feel free to close this until/unless I can repro again. Sorry for the confusion

Shadizar avatar Jun 08 '25 16:06 Shadizar

well shoot. this time it seemed to work, and I have no idea why, as I feel I did the exact same steps as I did the other time. I guess, feel free to close this until/unless I can repro again. Sorry for the confusion

!complain hahahaha

Moobien avatar Jun 14 '25 07:06 Moobien