minecolonies icon indicating copy to clipboard operation
minecolonies copied to clipboard

fixed potential memory leak

Open cyberNinja6143 opened this issue 1 year ago • 6 comments

Fixed a potential memory leak while investigating an issue a user was complaining about.

Changes proposed in this pull request:

  • Removed a variable that was not being used

[ *] Yes I tested this before submitting it. [ ] I also did a multiplayer test.

Review please

cyberNinja6143 avatar Jul 05 '24 20:07 cyberNinja6143

in java that is not a memory leak :D but we can remove the line if it isnt used

someaddons avatar Jul 05 '24 20:07 someaddons

in java that is not a memory leak :D but we can remove the line if it isnt used

Yeah but it still looks bad in the source code

cyberNinja6143 avatar Jul 05 '24 20:07 cyberNinja6143

I'm less concerned about visuals in code

someaddons avatar Jul 05 '24 20:07 someaddons

I'm less concerned about visuals in code

It is a bit of a silly change but I'm kind of a new developer

cyberNinja6143 avatar Jul 05 '24 20:07 cyberNinja6143

When you make contributions you have to follow our style guide, all code has to be formatted with our formatting rules. The space you removed is exactly against our formatting rules. So that has to be removed.

Thodor12 avatar Jul 05 '24 20:07 Thodor12

When you make contributions you have to follow our style guide, all code has to be formatted with our formatting rules. The space you removed is exactly against our formatting rules. So that has to be removed.

My bad, ill fix it

cyberNinja6143 avatar Jul 05 '24 20:07 cyberNinja6143