Luke Drummond

Results 33 comments of Luke Drummond

Since this is functionally NFC, but has the possibility to need rebasing several times would it be possible to please merge soon?

> This was intentional to keep headers in a more readable format. Define "readable".

> > > This was intentional to keep headers in a more readable format. > > > > > > Define "readable". > > If I recall correctly, the primary...

I just checked my above suggestion. This might use more or less vertical space than the existing version, since lines aren't off the right hand side. As an example: ```cpp...

Thanks for the reviews everyone. I've now updated the patch with the suggestions from [this comment](https://github.com/oneapi-src/unified-runtime/pull/1536#issuecomment-2069276875) The substantive changes are https://github.com/ldrumm/unified-runtime/commit/65322c47b7a2c3c3fbbea525ae1385543aa3763a [and](https://github.com/oneapi-src/unified-runtime/pull/1536/commits/4d518796c4b6af6a6d53a7e9690a66730286d9aa) https://github.com/ldrumm/unified-runtime/commit/c2610b26b22b4af87926319b81eec98f381ff1c3. The third commit, is simply the result...

@pbalcer Are your original concerns assuaged with the latest update?

> @pbalcer Are your original concerns assuaged with the latest update? ping @pbalcer

> > @pbalcer Are your original concerns assuaged with the latest update? > > ping @pbalcer ping @pbalcer

Sorry for letting this rot. I've just rebased it and we can hopefully try again.

The SPDX license identifier needs to be on its own line according to the spec: https://spdx.github.io/spdx-spec/v2.3/using-SPDX-short-identifiers-in-source-files/ python needs 4 space indents in the .editorconfig