react-native-transformable-image icon indicating copy to clipboard operation
react-native-transformable-image copied to clipboard

Update prop types dependency

Open pintocarlos opened this issue 6 years ago • 8 comments

  • Adds prop-types npm package.
  • Deprecates usage of React.PropTypes from 'react' npm package.
  • Adds missing .gitignore file with node_modules ignore

pintocarlos avatar Aug 30 '17 16:08 pintocarlos

@ldn0x7dc will you merge these and do a release? Otherwise @pintocarlos, how about forking this and releasing it?

dariocravero avatar Sep 25 '17 09:09 dariocravero

@pintocarlos This repo has a dependency that needs to b updated as well https://github.com/ldn0x7dc/react-native-view-transformer

Here: https://github.com/ldn0x7dc/react-native-view-transformer/blob/master/library/transform/ViewTransformer.js#L424

dmueller39 avatar Oct 24 '17 16:10 dmueller39

@dmueller39 I also added a PR for that dependency at the time of creating this issue: https://github.com/ldn0x7dc/react-native-view-transformer/pull/14

pintocarlos avatar Oct 24 '17 16:10 pintocarlos

@pintocarlos Ah! Looks like this needs to wait until that is merged + released so the dependency can be updated?

dmueller39 avatar Oct 24 '17 17:10 dmueller39

@brentvatne @dabit3 @ide Hey react-native-community folks, this is a semi popular repo that seems to have been orphaned by its maintainer. (there are several others as well) Would it be uncool to ask that it get forked on react-native-community?

It would be nice to have a process for this, because I've been running into a lot of issues with libraries that no one is maintaining anymore.

dmueller39 avatar Oct 24 '17 17:10 dmueller39

@dmueller39 The fact that this project is unmaintained is a strong reason not to add it to react-native-community IMO.

I’d recommend forking the project if you need custom changes yourself, sponsoring work on it, and building a new community of contributors if it’s actually important to you.

ide avatar Oct 24 '17 17:10 ide

also, this should be re-written using react-native-gesture-handler

brentvatne avatar Oct 24 '17 20:10 brentvatne

Thanks for the feedback.

dmueller39 avatar Oct 25 '17 09:10 dmueller39