Ludovic Fernandez

Results 1272 comments of Ludovic Fernandez

This is an old issue, I was a "young" lego maintainer at the time 😄. I was a maintainer for 3 days when this issue was opened. --- The need...

> acme.sh supports this workflow without contortions. I recommend avoiding this type of sentence: I call it "The Phantom Menace". You don't have the historical context of lego. You don't...

As explained inside the PR description: > The doc is missing because we need to agree together about the approach before writing it. Also, could you provide feedback about the...

In order for a pull request adding a linter to be reviewed, the linter and the PR must follow some requirements. - [x] The CLA must be signed ### Pull...

Related to https://github.com/golangci/golangci-lint/discussions/2881 --- FYI 0.0.x are not semver complaint because a bug fix cannot happen before a minor release or an impossible initial version v0.0.0. > PATCH version when...

https://github.com/DanilXO/filen/pull/1 The code review will start after the completion of the checkboxes (except for the specific items that the team will help to verify).

I already rechecked. The checks are based on the PR content, not your repo. You should tag your linter and update the PR accordingly.

The tests fail on Windows, the PR https://github.com/DanilXO/filen/pull/2 will fix that.

Based on real projects, the maximum of 500 lines is too small, so I changed it to 1000. https://github.com/ldez/golangci-lint-bench/issues/26#issuecomment-2434947090