hugo-flex icon indicating copy to clipboard operation
hugo-flex copied to clipboard
verified publisher icon ldeso

FIX multilingual URLs

Open pgrange opened this issue 3 years ago • 2 comments

pgrange avatar May 06 '22 21:05 pgrange

Hello, thank you very much for your pull request! I added some comments on your modifications. Could you please modify you code so that I can merge the PR?

Also, do you think it would make sense to change lines 18 and 22 with absLangURL in the file base.tpl.xml?

https://github.com/de-souza/hugo-flex/blob/e757432018f7c19d4a3657416b3e7354914c39e4/assets/xml/base.tpl.xml#L18 https://github.com/de-souza/hugo-flex/blob/e757432018f7c19d4a3657416b3e7354914c39e4/assets/xml/base.tpl.xml#L22

Cheers

ldeso avatar May 06 '22 23:05 ldeso

Hello @de-souza,

Thank you for your feedback.

Regarding base.tpl.xml I honestly don't know. It looks like it would make sense but I'm really a beginner with Hugo so I'm not sure what this would imply.

Regarding your comment on my modifications, I would be more than happy to apply them but, unfortunately I can't see it in GitHub. Neither on this conversation page, nor when I'm looking in the changes tab. What did I miss?

pgrange avatar May 07 '22 14:05 pgrange