Orphaned highlights

[peter-lyons-kehl]

Hi Laurent.

Related to #4 and its first example: Let's say you have existing Yawas highlights for a page, but the page changes subsequently and the text doesn't match the highlight in Yawas (whether full text, or "compressed"). Then you don't have a way of knowing that some of the existing/previous highlights are not visible on the page anymore.

Could Yawas somehow at least indicate that fact? And, if feasible, could it even show a list of those orphaned highlights, please? (For example, the "XYZ/PQR highlights" button at the bottom right could have a sub-buton, which would show those orphaned highlights in a popup, or in a separate tab.)

[ldenoue]

Thanks for the suggestion Peter. It now shows the number of highlights that could not be remapped. Next I'll try to add a link that actually shows you which ones couldn't be found.

[ldenoue]

Now it also shows you the missing highlights when you click on the red caption.

[peter-lyons-kehl]

Thanks for this new feature, Laurent.

I confirm that the red caption shows up when there is a missing highlight match. However, contrary to your screenshot above, I get

• the total "X/Z highlights" includes the number of missing highlights
• clicking at the red caption doesn't show missing ones.

That's with the current version 7.2.3 in Firefox. However, I'm running Firefox 72 Beta. I'll confirm this once 72 becomes release (as Firefox doesn't let me back to 71) in about a week.

[ldenoue]

Please try the 7.2.4 version. You can also load it from Github by cloning the repo and installing from source.

On Fri, Dec 13, 2019 at 9:16 PM Peter Kehl [email protected] wrote:

Thanks for this new feature, Laurent.

I confirm that the red caption shows up when there is a missing highlight match. However, contrary to your screenshot above, I get

• the total "X/Z highlights" includes the number of missing highlights
• clicking at the red caption doesn't show missing ones. [image: image] https://user-images.githubusercontent.com/4270240/70829011-72bab400-1da1-11ea-89f0-e762e4d98e0d.png

That's with the current version 7.2.3 in Firefox. However, I'm running Firefox 72 Beta. I'll confirm this once 72 becomes release (as Firefox doesn't let me back to 71) in about a week.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ldenoue/yawas/issues/5?email_source=notifications&email_token=AABEQOMNBWSA4VOLAEYYOADQYPUSNA5CNFSM4JZFA52KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEG3EKAQ#issuecomment-565593346, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABEQOM3U4QSJQB3JGIXGI3QYPUSNANCNFSM4JZFA52A .