yawas icon indicating copy to clipboard operation
yawas copied to clipboard

Site-specific G. logout indication

Open peter-lyons-kehl opened this issue 3 years ago • 1 comments

When using with Google Bookmarks, and visiting https://gregoryszorc.com/blog/2021/05/12/why-you-shouldn't-use-git-lfs - in either Firefox or Chrome, Yawas float says "Signed out". However, I'm definitely signed on to Google - I refreshed https://www.google.com/bookmarks several times, restarted the browser...

Yawas keeps saving highlights (to G. Bookmarks) for other websites, but fails for this one.

I looked at Browser Console (Ctrl+Shift+J), but there was no error/warning related to Yawas.

peter-lyons-kehl avatar May 17 '21 05:05 peter-lyons-kehl

Thanks @peter-kehl the URL contained a single quote ' character which made Yawas fail (more precisely, the encodeURIComponent used wasn't escaping the ' character, but Google was so Yawas didn't find the return URL to be the same and thought the user was signed out).

Fixed now with https://github.com/ldenoue/yawas/commit/06fb3878b8969e1501a324a76fe3e3bd4341b0b7

I submitted the new version to both Google and Firefox but of course you can install it directly from the source code.

ldenoue avatar May 17 '21 08:05 ldenoue