Laurent Demailly

Results 307 comments of Laurent Demailly

Sorry I wasn't clear. I meant not to ask how to disable a check, that's working fine with golangci-lint I meant to ask why is the code I linked being...

I tried the latest version, can you explain why: ```golang func MakeSimpleRequest(url string, r *http.Request, copyAllHeaders bool) *http.Request { req, err := http.NewRequestWithContext(r.Context(), http.MethodGet, url, nil) ... ``` makes it...

I am trying to ask and suggest if not that context check understands, without needing any special annotation that it is common to transfer/carry a context from http.Request

> Do we need a discussion/consensus on if/how setup-go should use this new capability? Yeah as a user and having many repos with CI I think what the go team...

meanwhile despite go-versions not having a PR, it works if you specify go1.22.2 (but it's cumbersome as mentioned before ^) output ``` Setup go version spec 1.22.2 Attempting to resolve...

~still not getting 1.22.3~ edit - I had pinned the version to 1.22.2 my bad

1.22 + latest:true works for me but will reiterate the lag due to manual review is less than desirable