nvim-ide icon indicating copy to clipboard operation
nvim-ide copied to clipboard

Bookmarks path cause setup failed on Windows

Open ErogeMaster225 opened this issue 2 years ago • 2 comments

The line below assume the user's operating system is Linux and will cause issues on Windows system because the default Neovim config folder path on Windows is different from Linux https://github.com/ldelossa/nvim-ide/blob/e81fbd084f10b92bb6a4f62155e0fa1edbee9c7e/lua/ide/components/bookmarks/component.lua#L13 Maybe you should use stdpath function to get the config folder instead

ErogeMaster225 avatar Nov 28 '22 14:11 ErogeMaster225

Hey there,

I am not a Windows user, so I'm going to lean on Windows users to fish out these issues and fix them. I will mark them as "help wanted".

ldelossa avatar Nov 28 '22 14:11 ldelossa

Sorry for late reply, about this issue i think BookmarksComponent.NotebooksPath = vim.fn.stdpath "config" .. "/bookmarks" should works on all platforms

ErogeMaster225 avatar Nov 29 '22 02:11 ErogeMaster225

Fixed via contribution

ldelossa avatar Dec 06 '22 12:12 ldelossa

@ErogeMaster225 @VidocqH

I just want to give you guys a heads up.

I am changing the encoding of notebook and bookmark files to base64 instead of sha256 so the strings can also be decoded.

This will ultimately allow for migration of bookmarks to a renamed repository, and a renamed file, if this occurs.

However, this will break existing bookmarks.

Since nvim-ide is so new, I do not want to put the sha256->base64 checks and conversions into the plugins. So expect any existing bookmarks and notesbooks to fail.

This should be the last time we have to deal with this interrupt.

ldelossa avatar Dec 06 '22 14:12 ldelossa