nvim-ide
nvim-ide copied to clipboard
ldelossa
Implement configurable panel sizes
Fixes #13
Let me know if this feels okay to you and I'll fix up the documentation.
Its a bit more of a refactor, but what do you think about opening up the "panels" config object a bit, so we dont spam a bunch of high level panel keys?
For instance:
panels = { left = { size = 30, panel_group = "explorer" } }
If you dont want to do a larger refactor in this PR, just lmk, and ill merge and refactor it a bit later.
I like that idea a lot more than how it is currently. I'll look at it in a bit here.
I thought I had commented on this last night but I guess not.
I might be able to work on the panels config some time this week if you don't get to it.
What I thought I had said last night is, basically, if you're still good with this PR then lets merge it - But now I'm thinking if we end up exposing more config options for the panels themselves, should we bother with this PR?
This PR is good and necessary. I think we just change the panel config structure as stated above. That will put us in a good place for more panel related configs in the future.
I think inability to configure default panel size is a big pain point for this plugin, IMO it should be fixed up (resolve merge conflicts) and merged, and it can be iterated on further.
Fixed up.
I think I have a way to tackle this in my head so I'll try and attack it tonight if no one else gets to it.
I think inability to configure default panel size is a big pain point for this plugin, IMO it should be fixed up (resolve merge conflicts) and merged, and it can be iterated on further.
Agreed 👌
@ldelossa Life stuff might get in the way of me being able to get to the refactor portion this week, so would you like to merge this or close it for now and wait for the refactor?
My vote would be to merge now and iterate further if needed. Not having this is a big pain point.
No worries!
Looks like it needs a rebase.
Does it? If so I'll check it out when I get home