Li Xuanji

Results 27 issues of Li Xuanji

Although the machine's `Install(VirtualApp)?` protocol allows an `initialState` parameter, it is not specified how to check that this is a "valid" initial state. Furthermore, the protocol produces a separate commitment...

📦 Contracts
🛑 Requirement
🛡️ Security
💻 Developer Experience
🔐 Protocol Related

description TBW

📦 Contracts
📖 Documentation

The checks in the `installApp` function checks that the passed-in appInstance has the correct appSeqNo and signingKeys; these could be avoided if the caller does not need to generate these

📦 Node
🧬 Code Quality

The return type is encoded in `GetAppInstancesResults`, an array of elements of type `AppInstanceInfo`, whose `timeout` field is of type `BigNumber`; however manual examination of the return type at https://github.com/counterfactual/monorepo/blob/master/packages/node/test/integration/get-app-instances.spec.ts#L108...

📦 Node
🧬 Code Quality

Could be confused with `appInstanceId`. Can be renamed to `appDefinitionAddr` for consistency.

📦 cf.js
good first issue

Create .gitattributes with the appropriate line to enable solidity syntax highlighting in the github web UI, as per github/linguist#3973

evaluating (integral cube 0 1 0.001) on 1-3-hop.html on chrome gets RangeError: Maximum call stack size exceeded, while (integral cube 0 1 0.01) works