Emit IBT/BTI instructions

[ibara]

trafficstars

Hi LDC developers --

OpenBSD moved to an IBT/BTI world. This causes binaries created with LDC to fail, as LDC does not emit the proper instructions for IBT/BTI.

This should be fixable with the addition of a flag that enables these instructions, as LLVM supports IBT/BTI very well.

[kinke]

Hi. Is this clang's -fcf-protection={return,branch,full}? That would set module flags according to https://github.com/ldc-developers/llvm-project/blob/c12d3509ebf75bb6a16798d5fed91acca86f7899/clang/lib/CodeGen/CodeGenModule.cpp#L771-L783

Is this supposed to be the default setting starting with what OpenBSD version? And OpenBSD only, not for FreeBSD etc.?

[ibara]

Hi. Yes. This is -fcf-protection=branch only. This is the default on OpenBSD -current today, which will eventually become OpenBSD 7.4.

OpenBSD only. The BSDs aren't like Linux. One should think of OpenBSD and FreeBSD as differently as you would think of Linux and FreeBSD.

[JohanEngelen]

Note: this should also set a __CET__ enum value. Or perhaps we should define __CET_x__ versions with x = 1,2,3.

// RUN: %clang -target i386-unknown-unknown -x c -E -dM -o - -fcf-protection=return %s | FileCheck %s --check-prefix=RETURN
// RUN: %clang -target i386-unknown-unknown -x c -E -dM -o - -fcf-protection=branch %s | FileCheck %s --check-prefix=BRANCH
// RUN: %clang -target i386-unknown-unknown -x c -E -dM -o - -fcf-protection=full %s   | FileCheck %s --check-prefix=FULL

// RETURN: #define __CET__ 2
// BRANCH: #define __CET__ 1
// FULL: #define __CET__ 3
void foo() {}

[JohanEngelen]

https://github.com/llvm/llvm-project/blob/fbe4ff8149a2b656a66cc0c64a38a5302c051c6e/clang/lib/CodeGen/CodeGenModule.cpp#L1015-L1027

[JohanEngelen]

This should be fixable with the addition of a flag that enables these instructions, as LLVM supports IBT/BTI very well.

@ibara I implemented just that. Is that sufficient? This would mean that OpenBSD ldc2 packaging would have to modify ldc2.conf by adding -fcf-protection, before building druntime&phobos.

[ibara]

This should be fixable with the addition of a flag that enables these instructions, as LLVM supports IBT/BTI very well.

@ibara I implemented just that. Is that sufficient? This would mean that OpenBSD ldc2 packaging would have to modify ldc2.conf by adding -fcf-protection, before building druntime&phobos.

I will test over the next few days and let you know.

[Nobody143745]

Please remember that aarch64 also needs this, the Clang flag for aarch64 is -mbranch-protection.

[JohanEngelen]

Please remember that aarch64 also needs this, the Clang flag for aarch64 is -mbranch-protection.

-mbranch-protection implementation in clang/llvm, see ARM::parseBranchProtection (LLVM lib function) and how it is used to generate function attributes by clang.