ldc icon indicating copy to clipboard operation
ldc copied to clipboard

`--disable-verify` should be the default

Open ghost opened this issue 2 years ago • 5 comments
trafficstars

LLVM IR verification is slow.

ghost avatar Nov 28 '22 04:11 ghost

Indeed, it speeds up the build at Weka by about 2%. (total, including SemA and linking) What's the downside? Silent miscompilation, or (better) crash?

JohanEngelen avatar Nov 29 '22 21:11 JohanEngelen

crash during object emission highly expected.

ghost avatar Dec 05 '22 11:12 ghost

Difference in compilation speed on 1.32.0 with and without --disable-verify: Screenshot_20230320_130014

Something's probably going pathological.

FeepingCreature avatar Mar 20 '23 12:03 FeepingCreature

@FeepingCreature can you clarify what the numbers are? Which one is for with, and which without --disable-verify ?

JohanEngelen avatar Mar 20 '23 17:03 JohanEngelen

Jenkins adds new builds at the top. Bottom row is without -disable-verify, top row is with -disable-verify.

FeepingCreature avatar Mar 20 '23 19:03 FeepingCreature