node-ldapjs icon indicating copy to clipboard operation
node-ldapjs copied to clipboard

fix #765

Open hillar opened this issue 3 years ago • 3 comments

hillar avatar Oct 25 '21 13:10 hillar

Can you add a test for this change?

UziTech avatar Oct 25 '21 17:10 UziTech

Can you add a test for this change?

there are already many in test/client.test.js


...
res.on('searchEntry', function (entry) {

      t.ok(entry instanceof ldap.SearchEntry)
 ...
res.on('searchReference', function (referral) {

    t.ok(referral instanceof ldap.SearchReference)

...      

hillar avatar Oct 25 '21 18:10 hillar

Those were passing before this change so they don't really show the need for this change.

UziTech avatar Oct 25 '21 19:10 UziTech

👋

On February 22, 2023, we released version 3 of this library. As a result, we are closing this issue/pull request.

Please see issue #839 for more information, including how to proceed if you feel this closure is in error.

jsumners avatar Feb 22 '23 19:02 jsumners