node-ldapjs icon indicating copy to clipboard operation
node-ldapjs copied to clipboard

Fork asn1 package

Open jsumners opened this issue 5 years ago • 4 comments

We shouldn't need to depend on an unmaintained asn1 package. Currently, we depend upon https://github.com/joyent/node-asn1. At the time of this writing, the most recent commits going back for a year are all related to internal build tools for Joyent's internal usage of the module. The module has several issues open and a few PRs that are basically ignored. We should fork this library, update it, and publish it under the @ldapjs namespace.

Or, and this is probably a better plan, we work with @panva to add BER encoding and decoding to https://github.com/panva/asn1.js

jsumners avatar May 27 '20 18:05 jsumners

If @panva is willing to add it, I think that would be the better option as well.

UziTech avatar May 27 '20 20:05 UziTech

He is not ;). I intend to keep the fork inline with the original package only without the browser polyfills and using native BigInt

panva avatar May 27 '20 20:05 panva

Thanks for responding @panva. :+1:

Well, I guess creating a package with the @ldapjs namespace it is.

UziTech avatar May 27 '20 21:05 UziTech

Fork repo created -- https://github.com/ldapjs/asn1

jsumners avatar May 31 '20 12:05 jsumners

👋

On February 22, 2023, we released version 3 of this library. As a result, we are closing this issue/pull request.

Please see issue #839 for more information, including how to proceed if you feel this closure is in error.

jsumners avatar Feb 22 '23 19:02 jsumners