node-ldapjs icon indicating copy to clipboard operation
node-ldapjs copied to clipboard

Bind requests & concurrency

Open lneveu opened this issue 6 years ago • 1 comments

Hi,

I'm using Verdaccio (a private npm proxy registry) with LDAP authentication (OpenLDAP 2.4.47) via the verdaccio-ldap plugin (that uses ldapauth-fork and node-ldapjs libs). I'm facing issues with authentication and, after digging into it, I found the "problem".

According to LDAP RFC (LDAPv3 RFC 4511 - section 4.2.1 https://www.ietf.org/rfc/rfc4511.txt), multiple "Bind Requests" should not be sent concurrently and must fullfil some requirements (see rfc). Unfortunatly, I don't think there is a mecanism either in ldapauth-fork or node-ldapjs to manage this and ensure that bind requests are performing synchronously (or wait for response to a bind before performing another).

Does each clients that using node-ldapjs (in my case ldapauth-fork) have to manage that or do you plan to do it internally?

lneveu avatar Feb 28 '19 14:02 lneveu

I do not know if this has ever been a consideration. If you'd like to submit a PR to implement this, I would certainly be willing to consider it.

jsumners avatar Aug 26 '19 13:08 jsumners

👋

On February 22, 2023, we released version 3 of this library. As a result, we are closing this issue/pull request.

Please see issue #839 for more information, including how to proceed if you feel this closure is in error.

jsumners avatar Feb 22 '23 19:02 jsumners