lain icon indicating copy to clipboard operation
lain copied to clipboard

Redundancy in alsabar and pulsebar widgets

Open lcpz opened this issue 6 years ago • 2 comments

It would be better to have a single widget, named bar, which can be feed with volume data from either ALSA or PulseAudio.

lcpz avatar Aug 12 '19 16:08 lcpz

Before knocking this out and sending you a PR, what do you think of this approach:

  • create a new widget volumebar to encompass common functionality and have an argument to switch between alsa and pulse
  • modify alsabar and pulsebar to wrap the volumebar widget to preserve backwards compatibility
  • somehow deprecate alsabar/pulsebar in the wiki or logging a deprecation warning

:+1: :-1: ?

gregflynn avatar Aug 27 '19 11:08 gregflynn

Sounds good.

lcpz avatar Aug 27 '19 16:08 lcpz