crane icon indicating copy to clipboard operation
crane copied to clipboard

Fixing Bug Related to ZapdosReactions Action and Updating MOOSE Submodule

Open csdechant opened this issue 7 months ago • 3 comments

This PR will do the following:

  • Fix a bug with the ZapdosReactions Action, where if the option track_rates = true is set, an error stating duplicate variables will occur. This is because of line 279 in file AddZapdosReactions.C was not needed due to line 286 (i.e., _problem->addAuxVariable was called twice for the same operation). Removing line 279 fixes the error and results in the expected outcome.
  • Update the MOOSE submodule for CRANE.

csdechant avatar Jul 21 '25 18:07 csdechant

@csdechant Can you push a new commit here updating the submodule again?

cticenhour avatar Sep 18 '25 18:09 cticenhour

I want to use this event to check some status on our CI config.

cticenhour avatar Sep 18 '25 18:09 cticenhour

Just did a commit --amend --no-edit push.

csdechant avatar Sep 18 '25 18:09 csdechant

@csdechant Can you remove the submodule update for MOOSE here, rebase, and re-push?

cticenhour avatar Nov 25 '25 17:11 cticenhour

Removed the MOOSE update and rebased on devel. Below is the link to CIVET testing: https://civet.inl.gov/pr/25301/

csdechant avatar Nov 25 '25 18:11 csdechant

@csdechant Double-check that the author email in your commit here is associated with your GitHub account. I cannot see the email you used in the GitHub UI, but the "Unverified" status of the commit is linked to the email not being known by GitHub. I cannot merge until this is fixed.

cticenhour avatar Nov 25 '25 21:11 cticenhour