jwt icon indicating copy to clipboard operation
jwt copied to clipboard

`5.7.x` is broken

Open Slamdunk opened this issue 2 months ago • 3 comments

I have no idea what happened, but 5.7.x branch is broken and not derived from 5.6.x: https://github.com/lcobucci/jwt/compare/5.7.x...5.6.x

Also, the default branch should be set back to 6.0.x

Slamdunk avatar Oct 17 '25 15:10 Slamdunk

Did it perhaps get created from 6.0.x? That seems really weird for https://github.com/laminas/automatic-releases/

Ocramius avatar Oct 17 '25 15:10 Ocramius

Event history:

  1. This morning only 5.5.x and 6.0.x existed, with the latter as default one
  2. I manually created 5.6.x from 5.5.x
  3. I manually created 5.6.0 milestone: https://github.com/lcobucci/jwt/milestone/62
  4. https://github.com/lcobucci/jwt/pull/1133 has been merged into 5.6.x
  5. 5.6.0 milestone has been closed by me

5.5.x, 5.6.x and 6.0.x seem fine to me.

5.7.x has been created from 6.0.x: https://github.com/lcobucci/jwt/compare/6.0.x...5.7.x Probably because at that time, 6.0.x was the default one.

I reckon we can delete 5.7.x altogether

Slamdunk avatar Oct 17 '25 16:10 Slamdunk

All commits from 5.7.x were brought to 6.0.x, 5.7.x was removed, and 6.0.x was made default

#1134 should be the only thing to do.

Probably because at that time, 6.0.x was the default one.

That sounds like a good theory to test in https://github.com/laminas/automatic-releases/ 🤔

lcobucci avatar Oct 24 '25 15:10 lcobucci