lcnr

Results 258 comments of lcnr

https://github.com/rust-lang/rust/issues/129541#issuecomment-2308823537 this uncovers a case where we forget ambiguity. Even if we're able to use an ambiguous candidate to normalize, this should force the goal to be ambiguous. This currently...

> [#129541 (comment)](https://github.com/rust-lang/rust/issues/129541#issuecomment-2308823537) this uncovers a case where we forget ambiguity. Even if we're able to use an ambiguous candidate to normalize, this should force the goal to be ambiguous....

Okay, so this issue contains 2 unintended changes: - #122493: for an enum `Hello`, when checking `Hello: Sized` we no-longer check whether the last field of each variant is `Sized`...

see https://github.com/rust-lang/rust/issues/129541#issuecomment-2325789416 @rfcbot fcp merge

please also add the 3 tests from https://github.com/rust-lang/rust/issues/129541#issuecomment-2325789416

no, to close this issue I would like to also want the following tests from my FCP proposal to get added as regression tests: - https://rust.godbolt.org/z/cz4ce7j84 - https://rust.godbolt.org/z/eqqoMqxxa - https://rust.godbolt.org/z/GMGKzYPEx

I want to merge the failing test to also catch when its behavior changes, even if it goes from pass to fail. I want to make sure we realize that...